Rename variables to full name variables #127
Conversation
| Challenge.create(guild, channel_id, chan.id, name) | ||
| chk_upd( | ||
| fullname, teams.update_one({"chan_id": cid}, {"$push": {"chals": chan.id}}) | ||
| fullname, teams.update_one({"channel_id": channel_id}, {"$push": {"chals": chan.id}}) |
There was a problem hiding this comment.
These database operations (update_one, find_one, etc.) might in fact be an issue as this would break old CTFs before this change.
I would say we should keep the key names (chan_id, etc.) for now and rather only change the Python variable names.
A solution to this would be to implement a legacy checker that would search for objects that match for example chan_id or channel_id, that should solve that issue.
|
Thanks for the help, this help with reading and understanding the code whenever someone else decides to read through it. Only issue is my comment above. As this bot is using MongoDB (NoSQL), it shouldn't take much to add a legacy operation that checks for example both I can have a take a look at this when I have time if you are unable to. |
2 participants
Rename variables to full name variables #120
changed:
cid,chan_id,ccid-->channel_iduid-->user_id